[PATCH 5/5] ARM: pxa: Fix recursive call of pxa_(un)mask_low_gpio()

Sergei Shtylyov sshtylyov at mvista.com
Mon Jan 10 07:04:58 EST 2011


Hello.

On 10-01-2011 2:29, Marek Vasut wrote:

> Signed-off-by: Marek Vasut<marek.vasut at gmail.com>
[...]

> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index 81edf97..96571fe 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -112,14 +112,14 @@ static void pxa_mask_low_gpio(unsigned int irq)
>   {
>   	struct irq_desc *desc = irq_to_desc(irq);

    You should have removed that variable too as it's not unused.

> -	desc->chip->mask(irq);
> +	pxa_mask_irq(irq);
>   }
>
>   static void pxa_unmask_low_gpio(unsigned int irq)
>   {
>   	struct irq_desc *desc = irq_to_desc(irq);

    Same here...

> -	desc->chip->unmask(irq);
> +	pxa_unmask_irq(irq);
>   }

WBR, Sergei



More information about the linux-arm-kernel mailing list