[PATCH v2 2/5] omap2plus: prm: Trvial build break fix for undefined reference to 'omap2_prm_read_mod_reg'
Kevin Hilman
khilman at ti.com
Fri Jan 7 16:14:07 EST 2011
Santosh Shilimkar <santosh.shilimkar at ti.com> writes:
[...]
>> I think it would be best to use WARN() on these, rather than
>> WARN_ONCE(). That's because these could be called from different
>> parts of the code base, and the stack backtrace will help someone
>> figure out all the code that needs to be fixed.
>>
>> Once you do that, this patch is
>>
>> Acked-by: Paul Walmsley <paul at pwsan.com>
>>
> With WARN() instead of WARN_ONCE() and Paul's ack, here
> is an updated patch.
Thanks, will queue for .38-rc cycle.
I'll again plead for working on your git-send-email setup. It looks
like your using outlook. The inline patch is wrapped (as outlook almost
always does.) The attached version applied fine, but the strong
preference is for a single inline patch.
Thanks,
Kevin
More information about the linux-arm-kernel
mailing list