[PATCH 1/1] arm: omap: gpio: define .disable callback for gpio irq chip

David Brownell david-b at pacbell.net
Fri Jan 7 04:00:44 EST 2011


> o lazy-disable state

This is an odd state, and confusion regularly
comes up ... I've never been a fan of having the
imperatively named disable_irq() act like a

disable_irq_at a_random_later_time_ _but_nyet().  If
one must have the latter function, clearer IMO
to name it better and have disable_irq()
do exactly that by the time it returns ... that
is after all what folk expect given its name and conventional interpretation of "disable".
 (ergo confusion when that's not what happens)

lazy_disable_irq() would be accurate, butI'm not
sure many folk would choose to use it.

- Dave




More information about the linux-arm-kernel mailing list