[PATCH v2 0/3] add CNS3xxx AHCI support

Jeff Garzik jgarzik at pobox.com
Thu Jan 6 18:17:56 EST 2011

On 01/06/2011 05:51 AM, Anton Vorontsov wrote:
> On Thu, Jan 06, 2011 at 02:43:08PM +0800, Lin Mac wrote:
> [...]
>>> It is overkill to rename the entirety of ahci_platform just for one override
>>> function.
>>> This sort of thing I would have expected to be added directly to
>>> ahci_platform.c.
>> It might be overkill for only one controller. but it is more clean and
>> readable to have different SoC specific changes in separate files,
>> especially when more SoCs need to make similar changes.
> I think that renaming the file is not necessary. You can just
> rename the module in the makefile.
> Personally I like the current approach more than putting
> controller-specific fixups directly into ahci_platform.

My main objection is the renaming.  If ahci_platform wants to export 
some symbols for SoC modules like ahci_platform_cns, that's ok.

In general, follow the library approach rather than linking modules 
together in strange ways.


More information about the linux-arm-kernel mailing list