[PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h
Arnaud Patard (Rtp)
arnaud.patard at rtp-net.org
Thu Jan 6 05:41:55 EST 2011
Sascha Hauer <s.hauer at pengutronix.de> writes:
> On Thu, Jan 06, 2011 at 02:59:36PM +0800, Richard Zhao wrote:
>> Hello Sascha,
>> On Thu, Dec 30, 2010 at 07:25:04PM +0800, Richard Zhao wrote:
>> > IOMUX_CONFIG_GPIO is not for iomux-v3. It's for old freescale
>> > iomux routines. Remove it.
>> > Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
>> > Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
>> If you don't have comments, could you please merge this patch?
>> It's causing arch/arm/plat-mxc/include/mach/iomux-mx50.h incomplete.
> I didn't apply it because it conflicts with current imx-for-2.6.38
> branch. Other than that I don't find the enum very useful at all,
> because we have problems with very long lines in these files and
> using IOMUX_CONFIG_ALT0 where we could use 0 does not exactly improve
> the situation.
While I agree with this, there's a small exception. I found out
yesterday that now, there's no more any macro/enum defined for the
infamous SION bit. Theses means that currently to defined a PAD with
SION bit set, we have to create a new macro with IOMUX_PAD instead
of using the _MX51_PAD_* macro as basis. Did I miss something ?
More information about the linux-arm-kernel