[PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h
richard.zhao at freescale.com
Thu Jan 6 05:29:19 EST 2011
On Thu, Jan 06, 2011 at 11:16:39AM +0100, Sascha Hauer wrote:
> On Thu, Jan 06, 2011 at 02:59:36PM +0800, Richard Zhao wrote:
> > Hello Sascha,
> > On Thu, Dec 30, 2010 at 07:25:04PM +0800, Richard Zhao wrote:
> > > IOMUX_CONFIG_GPIO is not for iomux-v3. It's for old freescale
> > > iomux routines. Remove it.
> > >
> > > Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> > > Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > If you don't have comments, could you please merge this patch?
> > It's causing arch/arm/plat-mxc/include/mach/iomux-mx50.h incomplete.
> I didn't apply it because it conflicts with current imx-for-2.6.38
> branch. Other than that I don't find the enum very useful at all,
> because we have problems with very long lines in these files and
> using IOMUX_CONFIG_ALT0 where we could use 0 does not exactly improve
> the situation.
Yes, correct. IOMUX_CONFIG_ALT0-7 is ok. But IOMUX_CONFIG_SION is more
readable than 0x1 << 4, isn't it? If you don't agree put IOMUX_CONFIG_SION
in iomux-v3.h, shall I put it in iomux-mx50.h?
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the linux-arm-kernel