[PATCH] arm: mach-omap2: pm: cleanup !CONFIG_SUSPEND handling

aaro.koskinen at nokia.com aaro.koskinen at nokia.com
Thu Jan 6 05:15:50 EST 2011


Kevin Hilman [khilman at ti.com]:
> Aaro Koskinen <aaro.koskinen at nokia.com> writes:
> > Make !CONFIG_SUSPEND init declarations identical on all OMAPs and
> > eliminate some ifdefs.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen at nokia.com>
> I like this solution, but it introduces compiler warnings:
> [...]
> As you likely noticed, removing the const leads to checkpatch warnings:
> WARNING: struct platform_suspend_ops should normally be const
> so the choice is between a checkpatch warning or a bunch of compiler
> warnings.
> Alternatively, I just posted a patch[1] to linux-pm propsing to fix this
> at the source.  Let's see what happens there.  Merging $SUBJECT patch
> will depend on how this is fixed upstream.

Sorry, I should have mentioned this when I posted the patch. I was aware of
this issue, but I thought this was already fixed in upstream. Check the following
commit in linux-next:


(suspend: constify platform_suspend_ops)


More information about the linux-arm-kernel mailing list