[PATCH 1/6] i2c-pxa: move i2c_pxa_remove to __devexit instead of just __exit

Ben Dooks ben-i2c at fluff.org
Wed Jan 5 04:19:15 EST 2011

On Wed, Jan 05, 2011 at 09:24:45AM +0100, Uwe Kleine-König wrote:
> a bit of explanation would be nice here.  Something like:
> 	Subject: i2c-pxa: make sure the remove callback is called on unbind 
> 	When a "pxa2xx-i2c" device was unbound (e.g. via sysfs) the remove
> 	callback was not called because it was discarded after boot or module
> 	load time.  Because of that the resources allocated in probe were not
> 	freed and so a rebind was impossible.
> 	Fix that by moving the remove callback to .devexit.text.
> This way everyone can understand that a real bug is fixed here.

agreed, please re-submit

Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

More information about the linux-arm-kernel mailing list