[PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
Tony Lindgren
tony at atomide.com
Tue Jan 4 18:17:21 EST 2011
* Kevin Hilman <khilman at ti.com> [110104 14:45]:
> On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> > Mika Westerberg <ext-mika.1.westerberg at nokia.com> writes:
> >
> > > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > > updating reg and l values. However, at the end of the function we
> > > perform a write:
> > >
> > > __raw_writel(l, reg);
> > >
> > > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > > correct (typically this points to GPIO_REVISION register).
> > >
> > > Fix this by returning immediately after call to
> > > set_24xx_gpio_triggering().
> > >
> > > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg at nokia.com>
> >
> > Acked-by: Kevin Hilman <khilman at ti.com>
> >
> > Tony, this should be added to omap-for-linus as it fixes a problem in
> > the recently merged GPIO omap_device/hwmod conversion.
>
> On second thought, it's a bit late for the main 2.6.38 window, so will
> queue this in my pm-fixes branch for the .38-rc cycle.
Yeah let's not mess with omap-for-linus right now, but instead start
queueing up fixes for -rc1.
Tony
More information about the linux-arm-kernel
mailing list