[PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM

Nicolas Pitre nicolas.pitre at linaro.org
Mon Aug 29 14:26:55 EDT 2011


On Tue, 30 Aug 2011, Bryan Wu wrote:

> On Mon, Aug 29, 2011 at 11:13 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Mon, Aug 29, 2011 at 09:18:29PM +0800, Bryan Wu wrote:
> >> Yeah, I replied that email with a patch to select LEDS_CLASS when
> >> CONFIG_NEW_LEDS=y.
> >
> > I don't see any point to that:
> >
> 
> Actually, what I really want to propose is to kill this option and
> build in leds-class.c when CONFIG_NEW_LEDS=y, since most of functions
> of leds-class.c are widely used by others.
> 
> And you know, to select it as default is a simple workaround.

Please go ahead with complete solutions when they exist.  We don't want 
the mainline source tree filled with simple workarounds.


Nicolas



More information about the linux-arm-kernel mailing list