[PATCH 1/5] ARM: mx5: Allow CCM definitions to work on MX51 and MX53

Sascha Hauer s.hauer at pengutronix.de
Sat Aug 27 14:39:22 EDT 2011

On Sat, Aug 27, 2011 at 12:17:47PM -0300, Fabio Estevam wrote:
> On Sat, Aug 27, 2011 at 8:19 AM, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > On Fri, Aug 26, 2011 at 04:21:57PM -0300, Fabio Estevam wrote:
> >> Allow CCM (Clock Control Module) definitions to work on MX51 and MX53
> >> by checking the cpu type in run-time and using the appropriate register bases.
> >
> > They already work on i.MX51 and i.MX53. They have different physical
> > addresses, but have (more or less accidently...) the same virtual
> > address.
> Without this patch I get a kernel crash on MX53 at
> arch/arm/mach-mx5/system.c , when trying to read
> the following registers CCM registers:

The CCM base address is AIPS1 + x whereas the ARM base address is
AIPS2 + x. Maybe only the AIPS1 base addresses are the same.
Anyway, I would prefer having the registers defines as offsets to
a base and not as absolute addresses. Looking back it was a mistake
merging this. Having the registers as offsets is much more flexible.


Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

More information about the linux-arm-kernel mailing list