[PATCH v14 REPOST 08/12] OMAP: dmtimer: add timeout to low-level routines

Santosh santosh.shilimkar at ti.com
Fri Aug 26 11:30:05 EDT 2011


On Friday 15 July 2011 05:34 PM, Tarun Kanti DebBarma wrote:
> The low-level read and write access routines wait on write-pending register
> in posted mode to make sure that previous write is complete on respective
> registers. This waiting is done in an infinite while loop. Now it is being
> modified to use timeout instead.
>
> Signed-off-by: Tarun Kanti DebBarma<tarun.kanti at ti.com>
> Reviewed-by: Varadarajan, Charulatha<charu at ti.com>
> Acked-by: Cousson, Benoit<b-cousson at ti.com>
> ---
>   arch/arm/plat-omap/include/plat/dmtimer.h |   34 ++++++++++++++++++++--------
>   1 files changed, 24 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap/include/plat/dmtimer.h
> index 53d5da6..6e34094 100644
> --- a/arch/arm/plat-omap/include/plat/dmtimer.h
> +++ b/arch/arm/plat-omap/include/plat/dmtimer.h
> @@ -36,6 +36,8 @@
>   #include<linux/delay.h>
>   #include<linux/platform_device.h>
>
> +#include<plat/common.h>
> +
>   #ifndef __ASM_ARCH_DMTIMER_H
>   #define __ASM_ARCH_DMTIMER_H
>
> @@ -230,6 +232,8 @@ int omap_dm_timers_active(void);
>   #define OMAP_TIMER_TICK_INT_MASK_COUNT_REG				\
>   		(_OMAP_TIMER_TICK_INT_MASK_COUNT_OFFSET | (WP_TOWR<<  WPSHIFT))
>
> +#define MAX_WRITE_PEND_WAIT            10000 /* 10ms timeout delay */
Minor comment.
Space out the comment with the tab or put it up.

Reviewed-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
Regards
Santosh



More information about the linux-arm-kernel mailing list