[PATCH 2/5] ARM: SAMSUNG: Make the sleep code common for S3C64XX and newer SoCs

[Kukjin Kim]

Abhilash Kesavan wrote:
> 
> The sleep code for S5PV210 and EXYNOS4 is identical; moreover it is quite
> similar
> to that for S3C64XX except for some SoC specific debug logic. S5P64X0 and
> S5PC100,
> for which support will be added soon, can also use the same procedure.
Create a
> common sleep code in the plat-samsung directory so that it can be re-used.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan at samsung.com>
> ---
>  arch/arm/mach-exynos4/Kconfig  |    1 +
>  arch/arm/mach-exynos4/Makefile |    2 +-
>  arch/arm/mach-exynos4/sleep.S  |   54 ---------------------------
>  arch/arm/mach-s3c64xx/Kconfig  |    1 +
>  arch/arm/mach-s3c64xx/Makefile |    1 -
>  arch/arm/mach-s3c64xx/sleep.S  |   72
------------------------------------
>  arch/arm/mach-s5pv210/Kconfig  |    1 +
>  arch/arm/mach-s5pv210/Makefile |    2 +-
>  arch/arm/mach-s5pv210/sleep.S  |   52 --------------------------
>  arch/arm/plat-samsung/Kconfig  |    7 +++
>  arch/arm/plat-samsung/Makefile |    1 +
>  arch/arm/plat-samsung/sleep.S  |   80
> ++++++++++++++++++++++++++++++++++++++++
>  12 files changed, 93 insertions(+), 181 deletions(-)
>  delete mode 100644 arch/arm/mach-exynos4/sleep.S
>  delete mode 100644 arch/arm/mach-s3c64xx/sleep.S
>  delete mode 100644 arch/arm/mach-s5pv210/sleep.S
>  create mode 100644 arch/arm/plat-samsung/sleep.S
> 

(snip)

> +ENTRY(s3c_cpu_resume)
> +#if defined(CONFIG_S3C_PM_DEBUG_LED_SMDK)
> +

Hi Abhilash,

Yes, would be nice if each sleep.S can be handled in plat-samsung for
Samsung SoCs.

Hmm...but the CONFIG_S3C_PM_DEBUG_LED_SMDK can be used on other SoCs for
same reason even though it is available only on S3C64XX now. I think, we
need to add SoC detecting here.

> +#undef S3C64XX_VA_GPIO
> +#define S3C64XX_VA_GPIO (0x0)

Please let me know why this is needed here.


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.