[PATCH 2/6] ARM: add Highbank core platform support

Arnd Bergmann arnd at arndb.de
Thu Aug 25 17:44:50 EDT 2011


On Thursday 25 August 2011 13:03:24 Rob Herring wrote:
> > 
> > Do you mean 'yes, they need to be global' or 'yes, it's better to export
> > the functions'?
> > 
> 
> I meant the former and functions as in h/w functionality, not C functions.
> 
> This will mainly be clock control plus a few other things. Is it really
> desired to add another layer here when these are all just single
> register writes?

It really depends on what the registers do, which I haven't seen. My feeling
is still that you should have an abstract interface for drivers to use,
but if the drivers need to do very little, exporting the symbol for the
base address and using it in inline functions from the header could be
appropriate.

	Arnd



More information about the linux-arm-kernel mailing list