How to handle named resources with DT?

Cousson, Benoit b-cousson at ti.com
Thu Aug 25 13:38:18 EDT 2011


On 8/25/2011 12:28 PM, Russell King - ARM Linux wrote:
> On Thu, Aug 25, 2011 at 02:16:14AM +0300, Felipe Balbi wrote:
>> on top of all that, for IPs which are used on many SoCs (such as MUSB)
>> it's quite silly to force all users to provide resources in a certain
>> order. It sounds to me that this will be prone to error in many ways
>> until everything is synced up and on the correct order.
>>
>> Ditching _byname is a very bad idea.
>
> I continue to disagree.  The current _byname is an abonimation and hack
> to try to "fix" this problem.

What problem are you considering here?

> _byname should have been implemented differently - rather than overriding
> the resources name field (which is _normally_ specified to be the device
> or driver name), a new field should have been introduced in struct resource
> to carry the resource sub-name (which is really what it is.)

I guess we agree on that, but that just means that the implementation is 
bad, not that the function is useless or evil.

> That would have avoided making /proc/iomem completely illegible with
> multiple devices using this feature.

resources are used as well for irq and dma, so that aspect is irrelevant 
in that case.

Assuming that a new field is added to keep the original semantic ot the 
name, will you be happy with the _byname API?

Benoit



More information about the linux-arm-kernel mailing list