[PATCH] ARM: imx: pwm: Add support for MX53
Lothar Waßmann
LW at KARO-electronics.de
Wed Aug 24 04:33:58 EDT 2011
Uwe Kleine-König writes:
> Hello Fabio,
>
> On Tue, Aug 23, 2011 at 01:26:38PM -0300, Fabio Estevam wrote:
> > Instead of adding the check for MX53 CPU type, use the negative logic and let
> > PWM to be configured for MX53 as well.
> I wonder why you prefer negative logic here. It might be shorter, but it
> is also less robust. For example it seems to me you not only added
> support for i.MX53 but also i.MX50.
>
> The IMHO best solution would be to use device ids and get rid of
> cpu_is_mx.. completely.
>
+1
Lothar Waßmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
More information about the linux-arm-kernel
mailing list