[PATCH v2] ARM: vexpress: Use wfi macro in platform_do_lowpower.

Jamie Iles jamie at jamieiles.com
Mon Aug 22 09:59:52 EDT 2011


On Mon, Aug 22, 2011 at 09:54:19AM -0400, Nick Bowler wrote:
> Current Versatile Express CPU hotplug code includes a hardcoded WFI
> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> mode, this is invalid and causes the machine to hang hard when a CPU
> is offlined.
> 
> Using the wfi macro (which uses the appropriate assembler mnemonic)
> causes the correct instruction to be emitted in either case.  As a
> consequence of this change, an apparently vestigial "cc" clobber is
> dropped from the asm (the macro uses "memory" only).
> 
> Signed-off-by: Nick Bowler <nbowler at elliptictech.com>
> ---

Reviewed-by: Jamie Iles <jamie at jamieiles.com>

if it helps!

Jamie



More information about the linux-arm-kernel mailing list