[PATCH 2/6] ARM: add Highbank core platform support

Shawn Guo shawn.guo at freescale.com
Mon Aug 22 05:15:12 EDT 2011


On Mon, Aug 22, 2011 at 04:35:26PM +0800, Shawn Guo wrote:
> On Tue, Aug 16, 2011 at 03:34:54PM -0500, Rob Herring wrote:
> > From: Rob Herring <rob.herring at calxeda.com>
> > 
> > This adds basic support for the Calxeda Highbank platform.
> > 
> > Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> > ---
> [...]
> > +void highbank_init_irq(void)
> > +{
> > +	struct device_node *node;
> > +	struct of_intc_desc desc;
> > +	int n = 0;
> > +
> > +	memset(&desc, 0, sizeof(desc));
> > +	desc.controller = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> > +	gic_of_init(&desc);
> > +	node = desc.controller;
> > +	for_each_child_of_node(node, desc.controller) {
> > +		gic_of_ppi_init(&desc);
> > +	}
> > +
> I failed to find the implementation of gic_of_ppi_init() in your patch
> series below.
> 
>   [RFC PATCH 0/3] Yet another GIC OF binding series
> 
I just found it in another private post you made to Marc.  (Marc made
it public with his reply)

> Also one nit: the braces seem redundant.
> 

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list