[PATCH] arm/imx: use Kconfig choice for low-level debug UART selection
Will Deacon
will.deacon at arm.com
Fri Aug 19 07:09:41 EDT 2011
Sascha,
On Fri, Aug 19, 2011 at 07:35:33AM +0100, Sascha Hauer wrote:
> On Fri, Aug 19, 2011 at 12:56:59PM +0800, Shawn Guo wrote:
> > Now that the DEBUG_LL UART can be selected by a Kconfig choice,
> > simplify the #ifdefery in debug-macro.S and add entries to the
> > top-level Kconfig.debug instead.
>
> I'm unsure whether I like this. The ifdeffery does not look very good,
> but the Kconfig snippet is not shorter, also it is in generic arm code
> and not i.MX specific. The old way also makes sure that we do not
> compile in incompatible lowlevel debug code.
But it's an unfortunate hinderence to a single zImage kernel which we can
only solve sensibly in the generic ARM code.
> At least this should be a choice in Kconfig to make clear that the
> different low-level debug options are exclusive.
As Shawn pointed out, we are using a Kconfig choice so you can only select
one UART for low-level debug output.
Will
More information about the linux-arm-kernel
mailing list