[PATCH v4] amba: consolidate PrimeCell magic

[H Hartley Sweeten]

On Thursday, August 18, 2011 12:59 AM, Linus Walleij wrote:
>
> Since two drivers use the PrimeCell scheme without using the
> amba_bus driver logic, let's break the magic lookups out as
> static inlines in the <linux/amba/bus.h> header so we get
> some consolidation anyway. Delete the primecell ID check in
> common/pl330.c since it is only used from the amba_bus driver
> in drivers/dma, which is already doing the same check when
> probing in drivers/amba/bus.c.
>
> Cc: Kukjin Kim <kgene.kim at samsung.com>
> Cc: Viresh Kumar <viresh.kumar at st.com>
> Acked-by: H Hartley Sweeten <hartleys at visionengravers.com>
> Acked-by: Jassi Brar <jassisinghbrar at gmail.com>
> Acked-by: Boojin Kim <boojin.kim at samsung.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> Changes V3->v4:
> - Fix up sparse warning due to inelegant cast to (u32) in vic.c,
>   we cast to (unsigned long) and sparse is happy.

Thanks!

One nit...

+	/*
+	 * Identify which VIC cell this one is, by reading the ID - some
+	 * implementations have two VICs in the same page but only one set
+	 * of ID registers at the end, so we need to adjust the base to
+	 * reference the page offset. All VIC:s are size 4K.
                                           ^

Is this supposed to be VIC's

Regards,
Hartley