[PATCH 17/18] mach-sa1100: retire custom LED code

Bryan Wu bryan.wu at canonical.com
Wed Aug 17 07:07:49 EDT 2011


On Mon, Aug 15, 2011 at 7:19 PM, Jochen Friedrich <jochen at scram.de> wrote:
> Hi Bryan,
>
>> diff --git a/arch/arm/mach-sa1100/badge4.c b/arch/arm/mach-sa1100/badge4.c
>> index b4311b0..2e370c6c 100644
>> --- a/arch/arm/mach-sa1100/badge4.c
>> +++ b/arch/arm/mach-sa1100/badge4.c
>> @@ -22,6 +22,8 @@
>>  #include<linux/mtd/mtd.h>
>>  #include<linux/mtd/partitions.h>
>>  #include<linux/errno.h>
>> +#include<linux/gpio.h>
>> +#include<linux/leds.h>
>>
>>  #include<mach/hardware.h>
>>  #include<asm/mach-types.h>
>> @@ -69,8 +71,36 @@ static struct platform_device sa1111_device = {
>>        .resource       = sa1111_resources,
>>  };
>>
>> +/* LEDs */
>> +struct gpio_led badge4_gpio_leds[] = {
>> +       {
>> +               .name                   = "badge4:red",
>> +               .default_trigger        = "heartbeat",
>> +               .gpio                   = 7,
>> +       },
>> +       {
>> +               .name                   = "badge4:green",
>> +               .default_trigger        = "cpu0",
>> +               .gpio                   = 9,
>> +       },
>> +};
>> +
>> +static struct gpio_led_platform_data badge4_gpio_led_info = {
>> +       .leds           = badge4_gpio_leds,
>> +       .num_leds       = ARRAY_SIZE(badge4_gpio_leds),
>> +};
>> +
>> +static struct platform_device badge4_leds = {
>> +       .name   = "leds-gpio",
>> +       .id     = -1,
>> +       .dev    = {
>> +               .platform_data  =&badge4_gpio_led_info,
>> +       }
>> +};
>> +
>>  static struct platform_device *devices[] __initdata = {
>>        &sa1111_device,
>> +       &badge4_leds;
>
> Typo. This should be &badge4_leds,
>

Thanks a lot, I will fix it and update my patches.
-Bryan



More information about the linux-arm-kernel mailing list