[PATCH v2 0/8] Clean up MXC and MXS mach/gpio.h

Shawn Guo shawn.guo at freescale.com
Wed Aug 17 02:25:40 EDT 2011


On Tue, Aug 16, 2011 at 09:19:50AM +0200, Sascha Hauer wrote:
> Shawn,
> 
> On Sun, Aug 14, 2011 at 12:13:59AM +0800, Shawn Guo wrote:
> > As one step to single image for multiple platforms, mach/gpio.h needs
> > to be removed from asm/gpio.h.  The patch set cleans up MXC and MXS
> > mach/gpio.h to an empty header.
> > 
> > It's based on v3.1-rc1 plus rmk's patch series below.
> > 
> >   [PATCH 00/13] Clean up mach/gpio.h headers
> > 
> > The Ben's fix is on the way to -rc2 through arm-soc tree.
> > 
> > Grant, Sascha,
> > 
> > Can you please review the series and give comments or your ack tag?
> 
> I'm fine with this series. I removed the dependency on rmks patches
> (can be easily merged later) and checked it into my cleanup branch.
> Please check if you are fine with the result.
> 
It looks all good in terms of code.  But the commit messages of the
following patches do not fit the context any more.

  arm/mxc: remove gpio_to_irq() from mach/gpio.h
  arm/mxc: move IMX_GPIO_NR into mach/hardware.h
  arm/mxs: move MXS_GPIO_NR into mach/mxs.h

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list