[PATCH kernel-3.0] arm:cache-l2x0: Fix L2 Cache size calculation.

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Aug 13 04:41:29 EDT 2011


On Fri, Aug 12, 2011 at 11:20:20AM +0100, Will Deacon wrote:
> On Fri, Aug 12, 2011 at 10:45:27AM +0100, Srinivas KANDAGATLA wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla at st.com>
> > 
> > This patch fixes L2 Cache size calculations for L2C-210, L2C-310 and
> > PL310, by changing the L2X0_AUX_CTRL_WAY_SIZE_MASK from 2 bits to 3
> > bits.
> > 
> > The Auxiliary Control Register for L2C-210, L2C-310 and PL310 has 3bits
> > [19:17] for Way size, however the existing code only uses 2 bits to
> > get this value. This results in incorrect cachesize calculations.
> > 
> > I should say this bug does not result in issue but, its just prints
> > incorrect values.
> 
> It also results in performing operations on the whole cache when we
> erroneously decide that the range is big enough (due to l2x0_size being
> too small).
> 
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla at st.com>
> 
> Acked-by: Will Deacon <will.deacon at arm.com>
> 
> Please can you CC stable on this too?

It's probably better to ask people to add a Cc: line to the _attributations_
rather than telling them to CC the stable tree with their email, and then
get a whinge from the stable maintainers about how that's not how to submit
patches for stable trees.



More information about the linux-arm-kernel mailing list