[PATCH 4/4] Move top level platform devices in sysfs to /sys/devices/soc/X

Greg KH gregkh at suse.de
Thu Aug 11 11:22:39 EDT 2011


On Thu, Aug 11, 2011 at 01:57:13PM +0200, Linus Walleij wrote:
> On 08/10/2011 05:02 PM, Greg KH wrote:
> >On Wed, Aug 10, 2011 at 02:03:42PM +0100, Lee Jones wrote:
> >>At the request of Arnd Bergmann this patch moves all SoC
> >>platform devices found in sysfs from /sys/devices/platform to
> >>/sys/devices/soc/<SoCNum>/. It is believed as the devices are
> >>SoC specific and a /sys/devices/soc node has recently become
> >>available, that this would be a more appropriate place to
> >>display the data.
> >And what userspace tools did you just break by doing this?
> 
> I think most of our userspace for this platform poking
> around in sysfs use /sys/class/* so should be pretty OK.
> 
> And none of which were properly documented in
> Documentation/ABI/* anyway, so do we care?
> grep -r 'devices/platform' Documentation/ABI/
> doesn't show anything relating to the ux500.
> 
> The major breakage would be out-of-tree stuff, if
> any.
> 
> Which is out-of-tree due to the absence of a SoC ID
> framework.
> 
> Which was nixed by Arnd et al precisely because
> the above change was not part of it.
> 
> It's a bit hard for Lee to please everyone with this
> one I suspect :-D

Ok, if you get guarantees from anyone using the in-kernel platform soc
code that this move is acceptable, and you guarantee that no userspace
tools will break, that's fine.  But odds are, you are going to break
something...

greg k-h



More information about the linux-arm-kernel mailing list