[PATCH] ARM: fix perf build with uclibc toolchains

Will Deacon will.deacon at arm.com
Wed Aug 10 06:21:55 EDT 2011


On Tue, Aug 09, 2011 at 09:08:53PM +0100, Will Deacon wrote:
> On Tue, Aug 09, 2011 at 12:24:17PM +0100, Florian Fainelli wrote:
> > libio.h is not provided by uClibc, in order to be able to test the
> > definition of __UCLIBC__ we need to include stdlib.h, which also
> > includes stddef.h, providing the definition of 'NULL'.
> > 
> > Signed-off-by: Florian Fainelli <florian at openwrt.org>
> > ---
> > diff --git a/tools/perf/arch/arm/util/dwarf-regs.c b/tools/perf/arch/arm/util/dwarf-regs.c
> > index fff6450..e8d5c55 100644
> > --- a/tools/perf/arch/arm/util/dwarf-regs.c
> > +++ b/tools/perf/arch/arm/util/dwarf-regs.c
> > @@ -8,7 +8,10 @@
> >   * published by the Free Software Foundation.
> >   */
> >  
> > +#include <stdlib.h>
> > +#ifndef __UCLIBC__
> >  #include <libio.h>
> > +#endif
> >  #include <dwarf-regs.h>
> >  
> >  struct pt_regs_dwarfnum {
> 
> Nice to see somebody trying to get this going with uclinux! I'll give this a
> quick compile-check on my boards and then I'll include it in my perf-fixes
> branch for 3.1.

Seems happy enough on my MMU boards. Since you're using this on noMMU
platforms, does that mean that you can build a static perf binary out of the
box or do you need further patches for this?

Will



More information about the linux-arm-kernel mailing list