[PATCH 2/3 v2] RFC: arm/kirkwood: add dreamplug support.

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Tue Aug 9 13:25:14 EDT 2011


Jason Cooper <jason at lakedaemon.net> writes:

Hi,

> Copied guruplug-setup.c and did s/guruplug/dreamplug/g.  Then, switched
> to SPI based NOR flash.  LED pins are correct.

Why don't use modify guruplug.c instead and use some if (machine_is_*)
tests to handle the differences like what was done for openrd ? I find
it quite wasteful to add a new machine file while (I guess) it should be
easier to modify existing code.

Regards,
Arnaud



More information about the linux-arm-kernel mailing list