[PATCH 1/5] ARM: hw_breakpoint: add initial Cortex-A15 (debug v7.1) support

Will Deacon will.deacon at arm.com
Mon Aug 8 14:10:33 EDT 2011


Hi Stephen,

On Mon, Aug 08, 2011 at 06:38:15PM +0100, Stephen Boyd wrote:
> On 08/08/2011 10:12 AM, Will Deacon wrote:
> > diff --git a/arch/arm/include/asm/hw_breakpoint.h b/arch/arm/include/asm/hw_breakpoint.h
> > index f389b27..0ac141a 100644
> > --- a/arch/arm/include/asm/hw_breakpoint.h
> > +++ b/arch/arm/include/asm/hw_breakpoint.h
> > @@ -50,6 +50,7 @@ static inline void decode_ctrl_reg(u32 reg,
> >  #define ARM_DEBUG_ARCH_V6_1	2
> >  #define ARM_DEBUG_ARCH_V7_ECP14	3
> >  #define ARM_DEBUG_ARCH_V7_MM	4
> > +#define ARM_DEBUG_ARCH_V7_1	5
> >  
> >  /* Breakpoint */
> >  #define ARM_BREAKPOINT_EXECUTE	0
> > diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
> > index a927ca1..9848157 100644
> > --- a/arch/arm/kernel/hw_breakpoint.c
> > +++ b/arch/arm/kernel/hw_breakpoint.c
> > @@ -154,7 +154,7 @@ u8 arch_get_debug_arch(void)
> >  static int debug_arch_supported(void)
> >  {
> >  	u8 arch = get_debug_arch();
> > -	return arch >= ARM_DEBUG_ARCH_V6 && arch <= ARM_DEBUG_ARCH_V7_ECP14;
> > +	return arch >= ARM_DEBUG_ARCH_V6 && arch <= ARM_DEBUG_ARCH_V7_1;
> 
> Is ARM_DEBUG_ARCH_V7_MM supported now too?

Ah, well spotted. I'd better fix that check before somebody thinks I'm
committing to supporting the memory-mapped interface!

Thanks,

Will



More information about the linux-arm-kernel mailing list