[PATCH 4/5] ARM: tegra: paz00: add clocks required for usboperation

[Stephen Warren]

Marc Dietrich wrote at Monday, August 08, 2011 11:19 AM:
> Hi Stephen,
> 
> On Monday 08 August 2011 18:57:52 Stephen Warren wrote:
> > Marc Dietrich wrote at Sunday, August 07, 2011 1:01 PM:
> > > These clocks are required for usb operation.
> >
> > ...
> >
> > > diff --git a/arch/arm/mach-tegra/board-paz00.c
> > > b/arch/arm/mach-tegra/board-paz00.c
> >
> > ...
> >
> > > @@ -145,6 +145,11 @@ static __initdata struct tegra_clk_init_table
> > > paz00_clk_init_table[] = {
> > >
> > >  	/* name		parent		rate		enabled */
> > >  	{ "uarta",	"pll_p",	216000000,	true },
> > >  	{ "uartd",	"pll_p",	216000000,	true },
> > >
> > > +
> > > +	{ "pll_a",      "pll_p_out1",   56448000,       true },
> > > +	{ "pll_a_out0", "pll_a",        11289600,       true },
> >
> > Are you sure those two are required for USB operation; they're typically
> > used for audio. Of course, this might just be a bug in the commit
> > description:-) Although, if you are attempting to enable audio, there's
> > a bunch more stuff that'd need to be done, including some more clock
> > setup.
> 
> Sorry, no audio yet :-(
> 
> But yes, you are right. I just found them by trial-and-error method, so somehow
> these creeped in. So I guess that the *_a* stands for audio?

Yes, that's the typical use of pll_a.

> Corrected patch coming soon.

+	{ "pll_p_out4", "pll_p",        24000000,       true },

Oh, and looking at the patches I recently posted to add USB support to
Harmony and Seaboard, which have been in the ChromeOS kernel for a while,
the USB clocks entries are typically e.g.:

        { "usbd",       "clk_m",        12000000,       true},
        { "usb3",       "clk_m",        12000000,       true},

Our internal Android kernel uses the same parent/rate setup for Harmony
too.

(there's a "usb2" too if you need; one per controller, so it depends which
are used on the AC100)

-- 
nvpublic