[PATCH] mach-davinci: fix cache flush build error

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Aug 2 12:02:34 EDT 2011


On Tue, Aug 02, 2011 at 05:48:38PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij at linaro.org>
> 
> The TNET variant of DaVinci compiles some code that it shares
> with other DaVinci variants, however it has a V6 CPU rather than
> an ARM926T, thus the hardcoded call to arm926_flush_kern_cache_all()
> in sleep.S will obviously fail, and we need to build with the
> v6_flush_kern_cache_all() call instead. This was triggered by
> manually altering the DaVinci config to build the TNET version.
> 
> Cc: Dave Martin <dave.martin at linaro.org>
> Cc: Arnd Bergmann <arnd at arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> This is just an ifdef to get the DaVinci TNET variant to compile,
> if there is a way to call out to some abstract flush function in a
> MULTI CPU/cache configuration from _assembler_ code, please tell me,
> 
> I'm not all that happy about this since it blocks proper multiboard
> support for DaVinci, would be nice to find a better solution.

Davinci seems to be a special case where it somehow preserves all state
even in deep sleep, which makes the generic cpu_suspend() not ideal for
it.

Or maybe that's just an oversight in the existing code - I don't know
so I haven't touched it.  I've been hoping that Davinci people can sort
it out...



More information about the linux-arm-kernel mailing list