[RFC/PATCH 7/7] WIP: HACK/RFC: omap_device: begin to decouple platform_device from omap_device
Russell King - ARM Linux
linux at arm.linux.org.uk
Mon Aug 1 19:09:45 EDT 2011
On Tue, Aug 02, 2011 at 01:55:55AM +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Aug 01, 2011 at 03:11:57PM -0700, Kevin Hilman wrote:
> > Russell King - ARM Linux <linux at arm.linux.org.uk> writes:
> >
> > > Help the typechecker do its job. As we have only one (at the moment...)
> > > And make it:
> > >
> > > +struct omap_device;
> > >
> > > struct pdev_archdata {
> > > +#ifdef CONFIG_ARCH_OMAP
> > > + struct omap_device *omap;
> > > +#endif
> > > };
> > >
> > > for bonus points, so we only get the additional pointer for OMAP.
> >
> > OK, will do it this way.
>
> this has the tendency to grow larger, no ? What if all other ARMs decide
> to add their own pointers there too ?
Their pointers for what? It's only OMAP which has this special omap_device
thing. Should that spread, instead of adding more pointers here, the work
should be to consolidate between those various implementations.
More information about the linux-arm-kernel
mailing list