[PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

Dmitry Torokhov dmitry.torokhov at gmail.com
Sun May 30 04:52:24 EDT 2010


On Sun, May 30, 2010 at 05:42:37AM +0200, Marek Vasut wrote:
> Dne Ne 30. května 2010 05:06:20 Joonyoung Shim napsal(a):
> > + */
> > +struct samsung_kp_platdata {
> > +	const struct matrix_keymap_data	*keymap_data;
> > +	unsigned int		rows;
> > +	unsigned int		cols;
> > +	unsigned int		rep;
> 
> I don't know, maybe using uint32_t here? On ARM, it doesn't matter so far as int 
> will be always 32bit, but maybe we should just type the variables well ?
> 
> Guys, what do you think ?
> 

I think unsigned int is fine, we do not care about particular size, just
need "big enough". I'd change 'rep' to be a boolean though.

Thanks.

-- 
Dmitry



More information about the linux-arm-kernel mailing list