[PATCH v2 1/5] ARM: SAMSUNG: Add keypad device support

Jassi Brar jassisinghbrar at gmail.com
Sun May 30 01:04:39 EDT 2010


On Sun, May 30, 2010 at 1:51 PM, Ben Dooks <ben-linux at fluff.org> wrote:
> On Sun, May 30, 2010 at 01:46:03PM +0900, Jassi Brar wrote:
>> On Sun, May 30, 2010 at 12:42 PM, Marek Vasut <marek.vasut at gmail.com> wrote:
>> > Dne Ne 30. kv??tna 2010 05:06:20 Joonyoung Shim napsal(a):
>> >> +struct samsung_kp_platdata {
>> >> +     const struct matrix_keymap_data *keymap_data;
>> >> +     unsigned int            rows;
>> >> +     unsigned int            cols;
>> >> +     unsigned int            rep;
>> >
>> > I don't know, maybe using uint32_t here? On ARM, it doesn't matter so far as int
>> > will be always 32bit, but maybe we should just type the variables well ?
>>
>> I thought int was 32bits on all archs
>
> No, the C standard doesn't make any guarantees about the size of types,
> it is up to the implementation of the compiler. If I rember correctly
> the only guarantee in the lanugage definition is that char->short->int->long
> be that the next up the line be at-least as a  big as the one before.
I believe on most implementations, if not all, sizeof char, short and
int are resp
1, 2 and 4 bytes. whereas long denotes the native capacity of the arch.



More information about the linux-arm-kernel mailing list