[PATCH] net/fec: fix pm to survive to suspend/resume
David Miller
davem at davemloft.net
Sat May 29 03:15:34 EDT 2010
From: Eric Bénard <eric at eukrea.com>
Date: Thu, 27 May 2010 19:53:48 +0200
> * with this patch, if the connection if active before suspend, it
> will be active after resume.
> * before this patch, it was necessary to close the interface and
> reopen it to recover the connection.
>
> Signed-off-by: Eric Bénard <eric at eukrea.com>
On resume the PHY should be reset and the link renegotiated (or set to
a fixed speed/duplex if set by the user via ethtool) just like as
happens on ->open().
You seem to be avoiding that here.
If the PHY is not functioning properly after the ->resume() triggered
reset, fix that instead.
I'm not applying this patch, it doesn't look the right thing to do at
all.
More information about the linux-arm-kernel
mailing list