[PATCH v3] i.MX27: add suspend to RAM support

Eric Bénard eric at eukrea.com
Thu May 27 16:54:40 EDT 2010


Le 27/05/2010 22:16, Russell King - ARM Linux a écrit :
> On Thu, May 27, 2010 at 10:06:04PM +0200, Eric Bénard wrote:
>> Do you think I should also fix this warning ?
>>
>> ./linux-2.6/scripts/checkpatch.pl
>> 0001-i.MX27-add-suspend-to-RAM-support.patch
>> WARNING: struct platform_suspend_ops should normally be const
>> #72: FILE: arch/arm/mach-mx2/pm-imx27.c:35:
>> +static struct platform_suspend_ops mx27_suspend_ops = {
>
> It's trivial enough to fix, and doesn't cause any issues by doing so,
> so I'd suggest adding the const.
>
well now this triggers the following warning so forget the patch v4, 
checkpatch seems wrong on this case :
   CC      arch/arm/mach-mx2/pm-imx27.o
arch/arm/mach-mx2/pm-imx27.c: In function 'mx27_pm_init':
arch/arm/mach-mx2/pm-imx27.c:42: warning: passing argument 1 of 
'suspend_set_ops' discards qualifiers from pointer target type

Eric



More information about the linux-arm-kernel mailing list