[PATCH 5/5] leds-gpio: Change blink_set callback to be able to turn off blinking

Richard Purdie rpurdie at rpsys.net
Wed May 26 07:05:37 EDT 2010


On Sat, 2010-05-22 at 20:54 +1000, Benjamin Herrenschmidt wrote:
> The leds-gpio blink_set() callback follows the same prototype as the
> main leds subsystem blink_set() one.
> 
> The problem is that to stop blink, normally, a leds driver does it
> in the brightness_set() callback when asked to set a new fixed value.
> 
> However, with leds-gpio, the platform has no hook to do so, as this
> later callback results in a standard GPIO manipulation.
> 
> This changes the leds-gpio specific callback to take a new argument
> that indicates whether the LED should be blinking or not and in what
> state it should be set if not. We also update the dns323 platform
> which seems to be the only user of this so far.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> CC: Richard Purdie <rpurdie at rpsys.net>
> CC: Grant Likely <grant.likely at secretlab.ca>
> ---
>  arch/arm/mach-orion5x/dns323-setup.c |   23 +++++++++++++----------
>  drivers/leds/leds-gpio.c             |   31 ++++++++++++++++++++++++-------
>  include/linux/leds.h                 |   12 ++++++++----
>  3 files changed, 45 insertions(+), 21 deletions(-)

Queued in the leds tree, thanks.

Richard




More information about the linux-arm-kernel mailing list