[PATCH v3 11/14] omap: mailbox: only compile for configured archs

Russell King - ARM Linux linux at arm.linux.org.uk
Mon May 24 17:00:50 EDT 2010


On Mon, May 24, 2010 at 10:29:01PM +0300, Felipe Contreras wrote:
> On Mon, May 24, 2010 at 5:42 PM, Hiroshi DOYU <Hiroshi.DOYU at nokia.com> wrote:
> > From: ext Felipe Contreras <felipe.contreras at gmail.com>
> 
> >> +     if (false);
> >
> > nitpcik:
> > The above may look better as below:
> >
> >        if (false)
> >                ;
> >
> > "checkpatch.pl" also doesn't complain.
> 
> Personally I think it looks weird and it's a checkpatch bug, but fine by me.

No, I'd say it's intentional.

	if (false);

looks too much like an error - think about:

	if (false);
		do_something();

which would be very easy to miss while reviewing.



More information about the linux-arm-kernel mailing list