[PATCH 0/4] Patches for -next

Catalin Marinas catalin.marinas at arm.com
Mon May 24 07:31:04 EDT 2010


On Fri, 2010-05-21 at 20:04 +0100, Russell King - ARM Linux wrote:
> On Fri, May 21, 2010 at 10:52:21AM +0100, Catalin Marinas wrote:
> > +     if (cache_is_vivt())
> > +             make_coherent(mapping, vma, addr, ptep, pfn);
> > +     else if (vma->vm_flags & VM_EXEC) {
> > +             __flush_icache_all();
> > +#ifdef CONFIG_SMP
> > +             set_pte_ext(ptep, __pte(pte_val(*ptep) | L_PTE_EXEC),
> > +                         addr >= TASK_SIZE ? 0 : PTE_EXT_NG);
> 
> You don't need this test - pages which have VMAs are userspace pages,
> and therefore the address is always < TASK_SIZE.  Therefore, they're
> always non-global:
> 
>                 set_pte_ext(ptep, __pte(pte_val(*ptep) | L_PTE_EXEC),
>                             PTE_EXT_NG);

Good point. Thanks.

So, are you ok for me to push these patches to -next?

-- 
Catalin




More information about the linux-arm-kernel mailing list