Hi Eric, > +#ifdef CONFIG_SPARSE_IRQ > +int __init arch_probe_nr_irqs(void) > +{ > + nr_irqs = arch_nr_irqs ? arch_nr_irqs : NR_IRQS; > + return 0; > +} > +#endif Possibly a daft question, but if CONFIG_SPARSE_IRQ is not set, where does nr_irqs get assigned to? Other than that, looks good to me. Cheers, Will