[PATCH 09/13] mxcmmc: add card detect through DAT3 possibility

Daniel Mack daniel at caiaq.de
Wed May 19 13:23:57 EDT 2010


On Wed, May 19, 2010 at 07:21:09PM +0200, Eric Bénard wrote:
> Le 19/05/2010 19:11, Daniel Mack a écrit :
> >>+	if (host->pdata &&  host->pdata->dat3_card_detect)
> >
> >As 0 is a valid GPIO, so you should use gpio_is_valid() here, and update
> >all users' pdata to set dat3_card_detect = -1, so it will fail this
> >test.
> >
> dat3_card_detect is not a GPIO number, it's just a flag to indicate
> that we want to use the internal detection feature provided by the
> mxcmci on DAT3 gpio (which is not used in GPIO mux).

I'm sorry. I should have had a closer look. Ignore me :)

Daniel



More information about the linux-arm-kernel mailing list