[PATCH] serial: SAMSUNG: Fix dev_name and driver_name
jy0922.shim at samsung.com
Tue May 18 02:00:26 EDT 2010
On 5/18/2010 2:36 PM, Ben Dooks wrote:
> On Tue, May 18, 2010 at 12:52:13PM +0900, Joonyoung Shim wrote:
>> On 5/18/2010 11:48 AM, Ben Dooks wrote:
>>> On Mon, May 17, 2010 at 09:46:50PM +0900, Joonyoung Shim wrote:
>>>> Thd dev_name and driver_name should be switched each other.
>>> Hmm, this doesn't seem to have appeard on the linux-arm-kernel list yet.
>>> Please provide some information about what problem that this is fixing
>>> and the impact on any existing systems.
>> The serial device nodes are created to s3c2410_serial* on android
>> platform instead of ttySAC*.
> This has been how they've been for ages, surely the android device node
> creation sytstem supports symlinking /dev/SACx -> /dev/s3c2410_serialx,
> like many other operating sysyerms that can already do this.
> Changing this just because android (something as-yet unmerged into mainline)
> does not like it. I'm not even happy with an #ifdef around this.
I don't want this too. I wonder if "s3c2410_serial" dev_name is correct?
Most serial drivers have tty prefix to dev_name, so i think ttySACx is more proper.
Please see other serial drivers.
More information about the linux-arm-kernel