[PATCH v2 8/9] Input: s3c24xx_ts - Adds TYPE_S5PV210 into Samsung touchscreen driver

Kukjin Kim kgene.kim at samsung.com
Fri May 14 03:09:15 EDT 2010


Ben Dooks wrote:
> 
> On Thu, May 13, 2010 at 10:07:28PM +0900, Kukjin Kim wrote:
> > From: Naveen Krishna <ch.naveen at samsung.com>
> >
> > This patch adds TYPE_S5PV210 to the ID table in Samsung touchscreen
driver.
> > So, we can configure the driver based on the IP level changes.
> 
> Hmm, what changes are those? Would much prefer to see the changes
> with these additions.
> 
> Also, how about the 'FEAT' flags idea that was floated, it may help
> with adding future SoCs.

The coming 2 patches would fix these changes.

> 
> > Signed-off-by: Naveen Krishna Ch <ch.naveen at samsung.com>
> > Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> > ---
> >  drivers/input/touchscreen/Kconfig      |    2 +-
> >  drivers/input/touchscreen/s3c2410_ts.c |    2 ++
> >  2 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/Kconfig
b/drivers/input/touchscreen/Kconfig
> > index c82c1e1..a90a5bb 100644
> > --- a/drivers/input/touchscreen/Kconfig
> > +++ b/drivers/input/touchscreen/Kconfig
> > @@ -159,7 +159,7 @@ config TOUCHSCREEN_FUJITSU
> >
> >  config TOUCHSCREEN_S3C2410
> >  	tristate "Samsung S3C2410 touchscreen input driver"
> > -	depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440
> > +	depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5P6440 ||
> ARCH_S5PV210
> >  	select S3C_ADC
> >  	help
> >  	  Say Y here if you have the s3c2410 touchscreen.
> > diff --git a/drivers/input/touchscreen/s3c2410_ts.c
> b/drivers/input/touchscreen/s3c2410_ts.c
> > index 7e7d368..8a970ea 100644
> > --- a/drivers/input/touchscreen/s3c2410_ts.c
> > +++ b/drivers/input/touchscreen/s3c2410_ts.c
> > @@ -89,6 +89,7 @@ enum s3c_cpu_type {
> >  	TYPE_S3C2410,
> >  	TYPE_S3C2440,
> >  	TYPE_S3C64XX,	/* S3C64XX, S5P64XX Series */
> > +	TYPE_S5PV210,	/* S5PV210 */
> >  };
> >
> >  /**
> > @@ -418,6 +419,7 @@ static struct platform_device_id s3cts_driver_ids[] =
{
> >  	{ "s3c2410-ts", TYPE_S3C2410 },
> >  	{ "s3c2440-ts", TYPE_S3C2440 },
> >  	{ "s3c64xx-ts", TYPE_S3C64XX },
> > +	{ "s5pv210-ts", TYPE_S5PV210 },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(platform, s3cts_driver_ids);
> > --


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list