[PATCH 11/11] ARM: S5P6440: Remove redundant defines
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu May 13 05:06:08 EDT 2010
On Thu, May 13, 2010 at 01:54:12PM +0900, Kyungmin Park wrote:
> On Thu, May 13, 2010 at 11:02 AM, Ben Dooks <ben-linux at fluff.org> wrote:
> > 1) It takes two lines of code, where one is sufficient.
> > 2) You only have to look in the relevant .c file to find out the
> > value instead of tracking down a header. This makes it easier
> > to verify the value against the manual and easier to compare
> > against simialr code.
> Then define it at c code and use the macro. I also don't like the
> hard-coded values.
I'm almost with Ben on this; but we can do better to satisfy both camps.
.ctrlbit = 1 << 2, /* CLKCON_MEM0_HCLK_NFCON */
It's now documented what the magic constant is.
More information about the linux-arm-kernel