[PATCH 11/11] ARM: S5P6440: Remove redundant defines

Jassi Brar jassisinghbrar at gmail.com
Wed May 12 21:49:29 EDT 2010


On Thu, May 13, 2010 at 9:28 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> From: Thomas Abraham <thomas.ab at samsung.com>
> --- a/arch/arm/mach-s5p6440/clock.c
> +++ b/arch/arm/mach-s5p6440/clock.c
> @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = {
>                .id             = -1,
>                .parent         = &clk_hclk.clk,
>                .enable         = s5p6440_mem_ctrl,
> -               .ctrlbit        = S5P_CLKCON_MEM0_HCLK_NFCON,
> +               .ctrlbit        = (1 << 2),
Peculiar. I have never seen defines dropped in favor of magic numbers.


More information about the linux-arm-kernel mailing list