[PATCH 1/2] nomadik hwrng: Add clock support

Alessandro Rubini rubini at unipv.it
Wed May 12 17:08:46 EDT 2010


> Looks good to me. Herbert, please queue this.

There are two details wrong, I hope Srinidhi sent V2 soon after this V1.

>> +struct clk *rng_clk;

This should be static.

The other problem is that there is no clock associated to this device,
it is only added by the later 2/2 patch.  So the rng stops working
with this patch alone, with this error:

>> +	rng_clk = clk_get(&dev->dev, NULL);
>> +	if (IS_ERR(rng_clk)) {
>> +		dev_err(&dev->dev, "could not get rng clock\n");
>> +		ret = PTR_ERR(rng_clk);
>> +		return ret;
>> +	}

I think the two patches  must be split differently. However, it's just
two minor details, so I am not against applying as-is, if the relevant
maintainer chooses to.

Thanks
/alessandro



More information about the linux-arm-kernel mailing list