[BUG] bug when enabling VM DEBUG

Sebastian Andrzej Siewior sebastian at breakpoint.cc
Wed May 12 07:53:40 EDT 2010


* Catalin Marinas | 2010-05-12 12:10:39 [+0100]:

>> > --- a/drivers/ata/libata-sff.c
>> > +++ b/drivers/ata/libata-sff.c
>> > @@ -894,7 +894,7 @@ static void ata_pio_sector(struct ata_queued_cmd *qc)
>> >                                         do_write);
>> >          }
>> >
>> > -       if (!do_write)
>> > +       if (!do_write&&  !PageSlab(page))
>> >                  flush_dcache_page(page);
>> 
>> I would think that check belongs inside flush_dcache_page itself, rather
>> than forcing every driver to include it..
>
>Sebastian (cc'ed) reported this as well for MIPS.
Thx. The patch above looks what I've sent a while ago. Jeff was going to
merge it afaik.

>I think it makes sense for this check to be done in the
>flush_dcache_page() function.

Why should flush_dcache_page() not flush pages you tell it?


More information about the linux-arm-kernel mailing list