[PATCH 05/16] ARM: S5PC100: new clocks definition

[Marek Szyprowski]

Hello,

On Wednesday, May 12, 2010 9:34 AM Kukjin Kim wrote:

> ...
> > >
> > > Marek,
> > >
> > > Actually, need to modify many part to fit new clock scheme.
> > > For example, to use clksrc_clk is easily to handle clock.
> >
> > I thought I covered most of the changes. Probably only the armclk
> > related functions and a cleanup in s5pc100/mach/regs-clock.h are
> > left and these can be easily fixed.
> >
> > > S.LSI already made the patch for C100 clock changing which is using
> > > clksrc_clk structure. So may I submit it?
> >
> > Could you compare your version with the final version that is created
> > by my patch series? I don't think that there will be many differences
> > there.
> >
> 
> There are defined clock source of C100 available clock in SYS.LSI patch
> like
> clocks defined by CLK_SRC1 register.
> SYS.LSI has covered all possible C100 clocks in our patch.

So this is rather a question of general policy about the clocks. Do we
really need to define them even if no driver would use it? I'm not
convinced. On the other hand defining all clocks now may reduce the driver
development time in the future. 
 
> So I think SYS.LSI patch provides more functionality based on Ben Dooks'
> new clock scheme.
> 
> How about check/review it after my submitting?

Maybe it would be possible to adapt it in such a way that it would be an
extension to the clocks defined by my patch series?

Ben, what do you think? Which way should we go?

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center