[PATCH 06/16] ARM: Samsung: move S5PC100 support from plat-s5pc1xx to plat-s5p framework

[jassi brar]

On Wed, May 12, 2010 at 3:40 PM, Marek Szyprowski
<m.szyprowski at samsung.com> wrote:
> Hello,
>
> On Wednesday, May 12, 2010 8:32 AM jassi brar wrote:
>
>> On Wed, May 12, 2010 at 2:54 PM, Marek Szyprowski
>> <m.szyprowski at samsung.com> wrote:
>> >> > @@ -79,6 +77,7 @@ static struct s3c2410_uartcfg smdkc100_uartcfgs[]
>> >> __initdata
>> >> > = {
>> >> >     },
>> >> >  };
>> >> >
>> >> > +#if 0
>> >>
>> >> #if 0?
>> >
>> > I had to disable that part of code to make it compile. It is enabled
>> later
>> > in separate patch when the relevant functionality got moved from plat-
>> s5pc1xx
>> > to mach-s5pc100.
>> build break is just one thing to avoid, one should make sure the
>> functionality
>> doesn't break either during the changes.
>> Is the functionality affected during these changes?
>
> It is, but I really see no way to preserve all functionality while moving
> from one platform framework to another. Please note that some of the files
>  stay in the same directory, but they are being changed heavily.
>
> The only possibility to preserve all functionality would be to squash all
> these patches into a single large blob, what we really would like to avoid.
The order of preference should be to avoid
   build break -> functionality break -> big patches.
Or is it just me?

Btw, it is ok to submit extra patches that do nothing but prepare
ground for a big change.

Having said that, I know perhaps practically no user would even notice/care
the transient break.