arm926_dma_flush_range undefined!

Thu May 6 13:59:07 EDT 2010

On Thu, May 06, 2010 at 03:07:11PM +0100, Catalin Marinas wrote:
> On Thu, 2010-05-06 at 15:11 +0200, Nicolas Ferre wrote:
> > I am trying to compile a recent kernel 
> > (v2.6.34-rc6-201-g722154e) and I am 
> > having this kind of error:
> > 
> > ERROR: "arm926_dma_flush_range" [drivers/mmc/host/at91_mci.ko] undefined!
> 
> The driver seems to use dmac_flush_range() directly. That's not part of
> the DMA API. Could you not use one of the supported DMA API functions?

Indeed; I've always said that I don't care about drivers directly using
the internals of the DMA API, and drivers doing this will be constantly
subjected to breakage.

I really do not regard the above to be a regression; it's a latent
programming error.  AT91 folk need to fix their driver(s) to use the
proper interfaces rather than using internal functionality.