[PATCH] arm: ARCH_REQUIRE_GPIOLIB selects GENERIC_GPIO

H Hartley Sweeten hartleys at visionengravers.com
Thu May 6 13:29:34 EDT 2010


On Monday, April 12, 2010 12:15 PM, Russell King wrote:
> On Mon, Apr 12, 2010 at 02:01:17PM -0500, H Hartley Sweeten wrote:
> On Monday, April 12, 2010 11:49 AM, Russell King wrote:
>>> On Thu, Apr 01, 2010 at 05:32:18PM -0500, H Hartley Sweeten wrote:
>>>> The ARCH_REQUIRE_GPIOLIB config option will select GPIOLIB which
>>>> in turn will select GENERIC_GPIO.  Because of this, there is no
>>>> reason to do the select GENERIC_GPIO in arch/arm/Kconfig for the
>>>> architectures that have ARCH_REQUIRE_GPIOLIB.
>>>
>>> This kind of patch normally causes regular merge conflicts, which
>>> historically have caused a repeated number of headaches - there's
>>> a similar patch for GENERIC_TIME which is pending.
>>>
>>> I suggest waiting until we're closer to the merge window than we
>>> are at present; I'll bring my devel stuff to a freeze state before
>>> hand so we can get these two patches merged - maybe around the
>>> -rc7 release.
>>>
>>> Please ping me closer to that.
>> 
>> Will do.
>> 
>> I just wanted to get this out there to make sure nobody saw any issues.
>> 
>> I will hold this until around -rc7 as you requested and just collect any
>> Ack's, etc., that show up.  Eric Miao has already sent an Acked-by that
>> I will add then.
>
> Also please keep an eye for any new places in -next where GENERIC_GPIO
> is selected as well as ARCH_REQUIRE_GPIOLIB - we're likely to see new
> platforms being added which may continue the old mistake.

Russell,

-rc7 should be coming soon.  Would you like this patch rebased now or after
Linus releases -rc7?  Also, I assume it should be rebased to linux-next or
would you prefer it rebased to one of your branches?

Regards,
Hartley



More information about the linux-arm-kernel mailing list