[RFC 07/10] arm: allow passing an ELF64 header to elf_check_arch()
ext-mika.1.westerberg at nokia.com
Tue Mar 30 03:26:32 EDT 2010
On Tue, Mar 30, 2010 at 01:41:24AM +0200, ext Jamie Lokier wrote:
> Mika Westerberg wrote:
> > This is needed to shut following compiler warning when CONFIG_PROC_VMCORE is
> > enabled:
> > fs/proc/vmcore.c: In function 'parse_crash_elf64_headers':
> > fs/proc/vmcore.c:500: warning: passing argument 1 of 'elf_check_arch' from
> > incompatible pointer type
> > ELF32 and ELF64 headers have common fields of same size (namely e_ident and
> > e_machine) which are checked in arm_elf_check_arch().
> Wouldn't it be better to just disable the elf64 code entirely on
> 32-bit archs, saving about half of the code size in vmcore.c which
> looks like it will never be called?
I took this approach from the other architectures that implement kdump.
At least on those archs that support both 32 and 64-bit both versions should be
supported. But I can add the required #ifdefs to vmcore code if preferred.
More information about the linux-arm-kernel